Feat: developed contribution section in project page #173

Bucky25 · 2020-12-06T17:24:15Z

Description

Used GitHub API to get commit data and made a contribution heat map for last 30 days
patch #80

Fixes #80

Type of Change:

Delete irrelevant options.

Code

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have tested the implementation and responsiveness.
here is the deployed link.
https://bucky25.github.io/anitab-org.github.io/

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have attached link of deployed site.
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings

nandini45 · 2020-12-12T17:46:30Z

@gaurivn can u test this PR??

tichnas · 2020-12-12T21:15:05Z

src/Components/Events/Cards/index.js

+import { withCard } from './../../../Decorators/Card';
+import Badge from './CardBadge';
+
+const EventCard = ({ props, isOver }) => {


Please remove isOver as it's not used anywhere

tichnas · 2020-12-12T21:16:01Z

src/Components/Events/Cards/index.js

+        <Badge text={props.location} link={require('./../../../assets/events_and_highlights/location.png')} />
+        <Badge text={props.timings} link={require('./../../../assets/events_and_highlights/time.png')} />
+        <View style={{marginTop: 32}}>
+            {props.description.map((detail,index) => (


use index as key in the child when using map

tichnas · 2020-12-12T21:17:13Z

src/Components/Events/index.js

+                marginTop: 30,
+              }}
+            >
+                {events_highlight.sections[1].events.map((event_detail,index) => (


Please remove index as it's not being used anywhere

tichnas

@Bucky25 I've requested some changes which I think should be done.
Also, please try to avoid inline styles and class components for consistency in the code and put all margins/paddings as a power of 2.

Thanks :)

tichnas · 2020-12-16T19:05:50Z

src/Components/Projects/Contribution/index.js

+    }
+];
+
+function Contribution ()  {


Use arrow function here for consistency as it's being used everywhere else.

tichnas · 2020-12-16T19:07:05Z

src/Components/Projects/index.js

@@ -5,6 +5,9 @@ import { View } from 'react-native';
 import ImageTextSection from './../ImageTextSection';
 import { getProjects } from './../../content/projects_content';
 import ProjectCard from './ProjectCard';
+import Calander from './Contribution';


Change Calander to Calendar

tichnas

Delete package-lock.json file as it isn't required for yarn package manager (which we are using).
Also, instead of using var, use const or let.

tichnas · 2020-12-16T19:15:46Z

src/Components/Projects/Contribution/ContributionRow.js

+import { View, Text, StyleSheet } from 'react-native';
+import ContributionBox from './Box';
+
+class ContributionRow extends React.Component {


Change class component to functional component (preferably arrow function).

I know both are same in terms of performance, but functional components are more concise and modern (and are used everywhere else). They don't have any disadvantages but may get optimized in future. Please refer https://www.twilio.com/blog/react-choose-functional-components for more information.

Do let me know if you face any trouble with functional components.

ok i will use useEffect there and it will be done

@Bucky25 Are you saying about componentDidMount? If yes, there is a React hook called useEffect which you can use (refer to the link shared above)

annabauza

Icons are wrong. @Vuyanzi @Sonal240 @simranaggarwal1999 can any of you provide proper icons please. Thanks a lot.

annabauza · 2020-12-23T12:15:57Z

src/Components/Content/index.js

@@ -12,7 +12,7 @@ function Content({ selected, titles }) {
    return <AboutUs />;
  } else if (selected === 3) {
    return <Projects />;
-  }
+  } 


Suggested change

}

}

annabauza · 2020-12-23T12:19:00Z

src/Components/Projects/Contribution/Box/index.js

+    var hue = 0;
+    switch (true) {
+
+        case (props < 2):


can't we just use interpolation here?

src/Components/Projects/Contribution/ContributionRow.js

annabauza · 2020-12-23T12:21:40Z

src/Components/Projects/Contribution/index.js

+import ContributionRow from './ContributionRow';
+import ContributionBox from './Box';
+
+const data  = [


move this to content folder please.

annabauza · 2020-12-23T12:22:42Z

src/Components/Projects/Contribution/index.js

+                    }
+                <View style={styles.description}>
+                   <Text style={styles.text}>Less</Text> 
+                   <ContributionBox props={1} />


I think it will be good to rename it from props. The name is misleading.

annabauza · 2020-12-23T12:29:45Z

is this the same PR as #171 ?

Vishal-raj-1 · 2021-01-29T17:34:17Z

@Bucky25 Please squash your commits into one commit !!

annabauza · 2021-01-31T14:05:38Z

@Vishal-raj-1 we squash when merge. No need to squash.

Vishal-raj-1 · 2021-01-31T14:44:27Z

@annabauza that's great !!

Bucky25 · 2021-02-01T18:48:55Z

@Vishal-raj-1 we squash when merge. No need to squash.

@annabauza thanks

nandini45 · 2021-02-16T21:46:34Z

@Bucky25 any pending work needs to be done in the pr??

Bucky25 · 2021-02-18T11:15:58Z

@Bucky25 any pending work needs to be done in the pr??

@nandini45 i think its done i have done all the changes required ?

nandini45 · 2021-02-18T13:17:54Z

@Bucky25 yes i will ping Anna again for her review
sorry for the delay. you can look for other issues if you want
thanks

annabauza

100

annabauza · 2021-01-23T22:26:51Z

src/Components/Projects/Contribution/Box/index.js

+
+const ContributionBox = ({ commitCount }) => {
+    var hue = 0;
+    switch (true) {


This is dodgy i think simple if else would do here

done @annabauza please check it

Vishal-raj-1 · 2021-02-19T06:48:11Z

@Bucky25 It contains conflicting files. Resolve it !!

as files already present

Bucky25 · 2021-02-19T09:29:59Z

@annabauza please remove these files:
src/assets/events_and_highlights/calendar.png
src/assets/events_and_highlights/location.png
src/assets/events_and_highlights/time.png
as they are not correct png for icons then merging is all fine

nandini45 · 2021-02-27T20:27:53Z

@annabauza can you please provide your feedback ?

keshakaneria · 2021-03-08T05:36:26Z

@Bucky25 any updates about solving the conflicts?

Bucky25 · 2021-05-05T20:14:12Z

@Bucky25 any updates about solving the conflicts?

i already mentioned that these files are existing in the repo and are different from pr because new one are that png files .

nandini45 · 2021-05-06T18:17:16Z

@annabauza can you review the PR please?

nandini45 · 2021-09-29T04:56:01Z

@isabelcosta Can you review the PR ?

isabelcosta · 2021-10-04T22:13:19Z

@isabelcosta Can you review the PR ?

I can try but my frontend skills are a bit rusty, could you ask Zulip to see if anyone wants to help. @nandini45

isabelcosta · 2021-10-17T20:23:45Z

@Bucky25 are you still interested in finishing this issue?

Bucky25 added 4 commits December 2, 2020 21:33

made cards and developed event section (anitab-org#123)

88b86e9

develop contribution section in project page anitab-org#80

fafb091

develop contribution section in project page

1c7ef02

develop contribution section in project page anitab-org#80

ea584eb

tichnas reviewed Dec 12, 2020

View reviewed changes

tichnas suggested changes Dec 12, 2020

View reviewed changes

tweaked styles and cosole errors

760ce7b

tichnas reviewed Dec 16, 2020

View reviewed changes

tichnas suggested changes Dec 16, 2020

View reviewed changes

tichnas reviewed Dec 16, 2020

View reviewed changes

Bucky25 added 2 commits December 17, 2020 14:14

removed gramatical errors

ae68497

removed class component and added functional component

0f8f20d

isabelcosta added the Status: Needs Review PR needs an additional review or a maintainer's review. label Dec 22, 2020

annabauza requested changes Dec 23, 2020

View reviewed changes

annabauza mentioned this pull request Dec 23, 2020

Feat: made cards and developed event section (anitab-org#123) #171

Merged

5 tasks

annabauza added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Dec 23, 2020

Bucky25 added 2 commits December 26, 2020 16:13

moved data to content , renamed props and added scrollview

2096684

added data to content and added scrollview

650b8a8

Bucky25 force-pushed the contribution-_heat_map branch from 2acb6a8 to 650b8a8 Compare December 26, 2020 10:56

Merge branch 'develop' into contribution-_heat_map

31151ea

Bucky25 requested a review from annabauza January 1, 2021 15:33

annabauza approved these changes Feb 18, 2021

View reviewed changes

Bucky25 added 2 commits February 18, 2021 22:03

Minor tweaks

9600127

Minor tweaks

92b93a3

removed conflicting files

508de9e

as files already present

Bucky25 requested a review from annabauza May 5, 2021 20:11

Feat: developed contribution section in project page #173

Are you sure you want to change the base?

Feat: developed contribution section in project page #173

Conversation

Bucky25 commented Dec 6, 2020 • edited by isabelcosta Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

nandini45 commented Dec 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tichnas left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tichnas left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annabauza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annabauza commented Dec 23, 2020

Vishal-raj-1 commented Jan 29, 2021

annabauza commented Jan 31, 2021

Vishal-raj-1 commented Jan 31, 2021

Bucky25 commented Feb 1, 2021

nandini45 commented Feb 16, 2021

Bucky25 commented Feb 18, 2021

nandini45 commented Feb 18, 2021

annabauza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vishal-raj-1 commented Feb 19, 2021

Bucky25 commented Feb 19, 2021

nandini45 commented Feb 27, 2021

keshakaneria commented Mar 8, 2021

Bucky25 commented May 5, 2021

nandini45 commented May 6, 2021

nandini45 commented Sep 29, 2021

isabelcosta commented Oct 4, 2021

isabelcosta commented Oct 17, 2021

Bucky25 commented Dec 6, 2020 •

edited by isabelcosta

Loading

tichnas left a comment •

edited

Loading

tichnas left a comment •

edited

Loading